Containers and PCL point type for backwards compatibility #347
Containers and PCL point type for backwards compatibility #347spuetz wants to merge 8 commits intoros-drivers:melodic-develfrom
Conversation
|
We should have this also in the master for |
| container_ptr_ = getContainer(default_container_.second); | ||
| } | ||
| ROS_WARN_STREAM("Using default container \"" << container_name << "\"!"); | ||
| ROS_WARN_STREAM("Please use the \"container\" param with one of the following container names: " << container_list.str()); |
There was a problem hiding this comment.
Please either do one of the following:
- Add the
containerparameter to all launch files and set it to the un-organized default ofPointCloudXYZIR; or - Set this to be an
INFOstatement instead of a warning.
Having the new default value cause a warning seems problematic and could unnecessarily alarm users. I would prefer the first option since it should also be accompanied by some documentation with the possible values in the launch file.
There was a problem hiding this comment.
I also prefer the first option! Will do that.
| } | ||
| EIGEN_ALIGN16; | ||
|
|
||
| }; // namespace velodyne_pointcloud |
There was a problem hiding this comment.
Shouldn't we also define the PointXYZIRT in terms of a PCL structure so people can use it in the same way?
There was a problem hiding this comment.
Yes for melodic that makes sense. For noetic, I'll move this to the velodyne_pcl package.
There was a problem hiding this comment.
This item still needs to be done.
|
@spuetz Can you please address my concerns? After that, I'll see if I can find a package to test with. |
|
@spuetz ping for changes. |
|
@spuetz Any update here? |
|
Sorry for the late reply. I'll have time in two weeks to finish this. |
|
Thanks, @spuetz! |
|
@spuetz ping |
|
@spuetz Still two items remaining when you can make time. |
|
@spuetz Can we get this wrapped up? |
|
Any update on this? @spuetz @JWhitleyWork |
JWhitleyWork
force-pushed
the
containers_and_pcl
branch
from
ca6c24b to
0305426
Compare
|
Rebased on current |
3 participants
This is a possible solution for #340 for melodic.
point_type.his added again.organized_cloudXYZIRT.cc.Things to do before merging / releasing
point_type.hshould test this.velodyne_pclpackage (Velodyne pcl #335)convert.handtransform.h, since it more or less identical now. (Unify tf frame parameters between transform and cloud nodes (Backport of #344 to Melodic) #351)