Skip to content

Don't validate data_out if it is empty (backport #391) #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 12, 2025

ros-controls/ros2_controllers#560 fails because filter_chains does not initialize intermediate output variables, which makes the assertion data_in.header.frame_id == data_out.header.frame_id fail.

I also changed the assertions to throwing exceptions, using fmt to concatenate numbers and strings.


This is an automatic backport of pull request #391 done by Mergify.

(cherry picked from commit 04c1a2e)

# Conflicts:
#	control_toolbox/include/control_toolbox/filter_traits.hpp
@mergify mergify bot added the conflicts label Jun 12, 2025
Copy link
Author

mergify bot commented Jun 12, 2025

Cherry-pick of 04c1a2e has failed:

On branch mergify/bp/jazzy/pr-391
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 04c1a2e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   control_toolbox/CMakeLists.txt
	modified:   control_toolbox/package.xml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   control_toolbox/include/control_toolbox/filter_traits.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (226ea4a) to head (a91083c).

Additional details and impacted files
@@           Coverage Diff           @@
##            jazzy     #406   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files          29       29           
  Lines        1787     1787           
  Branches      106      106           
=======================================
  Hits         1335     1335           
  Misses        390      390           
  Partials       62       62           
Flag Coverage Δ
unittests 74.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich
Copy link
Contributor

@saikishor we havent backported #351?

@saikishor
Copy link
Member

@saikishor we havent backported #351?

Ok. Sorry I missed that part

@saikishor saikishor closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants