Skip to content

Make link visible in redirect instructions #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Make link visible in redirect instructions #387

wants to merge 3 commits into from

Conversation

peterdesmet
Copy link
Member

@peterdesmet peterdesmet commented Feb 15, 2022 •
edited
Loading

Link appeared as:

Test that https://.github.io//index.html now redirects

Should now appear as:

Test that https://<username>.github.io/<pkgname>/index.html now redirects

In addition: close meta tag with regular > not />

I'm also wondering if the Javascript is necessary? This redirect seems to work fine:

<!DOCTYPE html>
<meta charset="utf-8">
<title>Redirecting https://inbo.github.io/wateRinfo/</title>
<meta http-equiv="refresh" content="0; URL=https://ropensci.github.io/wateRinfo/">
<link rel="canonical" href="https://ropensci.github.io/wateRinfo/">

Or even shorter:

<html>
  <head>
    <meta http-equiv="refresh" content="0; URL=https://docs.ropensci.org/frictionless/">
    <link rel="canonical" href="https://docs.ropensci.org/frictionless/">
  </head>
</html>

This works for https://frictionlessdata.github.io/frictionless-r/ (source file)

@maelle
Copy link
Member

maelle commented Feb 16, 2022

Noting that https://frictionlessdata.github.io/frictionless-r/reference is not redirected (not even sure our previous recommendations would deal with this, will investigate)

@peterdesmet
Copy link
Member Author

Indeed, subpages are not redirected. Curious indeed if Javascript code in previous recommendation would do that.

@maelle
Copy link
Member

maelle commented Feb 16, 2022

I'm guessing not, though. 🤔

⚠️ Not an actual recommendation, it just works "for me" ⚠️ I have written code for replacing all previous HTML pages of another package but that's probably not optimal. At least it works: https://gist.github.com/maelle/278d2424baa118467960d463d745f083

@maelle
Copy link
Member

maelle commented Feb 17, 2022

@peterdesmet I've added guidance on the filename to use (404.html). I'll close this PR but I'll make the change to the dev branch of the dev guide and add your address in the commit. Thank you!

@maelle
Copy link
Member

maelle commented Feb 17, 2022

Here is the commit 22b9198

Thanks a lot for your contribution!

@maelle maelle closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdesmet @maelle