dataframe_concurrency LLVM valgrind error: SelectionDAG::Combine

[Axel-Naumann]

• Checked for duplicates

Describe the bug

valgrind ... --suppressions=etc/valgrind-root.supp tree/dataframe/test/dataframe_concurrency gives

==30221== Conditional jump or move depends on uninitialised value(s)
==30221==    at 0x9D14829: (anonymous namespace)::DAGCombiner::visitOR(llvm::SDNode*) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x9D4BF24: (anonymous namespace)::DAGCombiner::visit(llvm::SDNode*) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x9D4D13E: (anonymous namespace)::DAGCombiner::combine(llvm::SDNode*) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x9D4EA0D: llvm::SelectionDAG::Combine(llvm::CombineLevel, llvm::AAResults*, llvm::CodeGenOpt::Level) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x9E2B521: llvm::SelectionDAGISel::CodeGenAndEmitDAG() (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x9E2F293: llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x9E3214B: llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) [clone .part.0] (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x98D5399: (anonymous namespace)::X86DAGToDAGISel::runOnMachineFunction(llvm::MachineFunction&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x9FE37CA: llvm::MachineFunctionPass::runOnFunction(llvm::Function&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0xB1BAA47: llvm::FPPassManager::runOnFunction(llvm::Function&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0xB1BAAD0: llvm::FPPassManager::runOnModule(llvm::Module&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0xB1B9A9F: llvm::legacy::PassManagerImpl::run(llvm::Module&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x965F899: llvm::orc::SimpleCompiler::operator()(llvm::Module&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x84B1E3A: std::_Function_handler<llvm::Expected<unsigned long> (), llvm::orc::LazyEmittingLayer<llvm::orc::LegacyIRCompileLayer<cling::IncrementalJIT::RemovableObjectLinkingLayer, llvm::orc::SimpleCompiler> >::EmissionDeferredModule::find(llvm::StringRef, bool, llvm::orc::LegacyIRCompileLayer<cling::IncrementalJIT::RemovableObjectLinkingLayer, llvm::orc::SimpleCompiler>&)::{lambda()#1}>::_M_invoke(std::_Any_data const&) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x84A2F16: cling::IncrementalExecutor::executeWrapper(llvm::StringRef, cling::Value*) const (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x8441754: cling::Interpreter::RunFunction(clang::FunctionDecl const*, cling::Value*) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x844457C: cling::Interpreter::EvaluateInternal(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cling::CompilationOptions, cling::Value*, cling::Transaction**, unsigned long) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x8349A5F: TCling::Calc(char const*, TInterpreter::EErrorCode*) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221==    by 0x48F1A4D: ROOT::Internal::RDF::InterpreterCalc(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /home/axel/build/root/24/rel/lib/libROOTDataFrame.so)
==30221==    by 0x48FA766: ROOT::Detail::RDF::RLoopManager::Jit() (in /home/axel/build/root/24/rel/lib/libROOTDataFrame.so)
==30221==    by 0x49030D3: ROOT::Detail::RDF::RLoopManager::Run() (in /home/axel/build/root/24/rel/lib/libROOTDataFrame.so)
==30221==    by 0x153A71: SimpleParallelRDFs()::{lambda()#1}::operator()() const [clone .isra.0] (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x153AD5: std::_Function_handler<void (unsigned int), std::vector<std::result_of<SimpleParallelRDFs()::{lambda()#1} ()>::type, std::allocator<std::result_of<SimpleParallelRDFs()::{lambda()#1} ()> > > ROOT::TThreadExecutor::MapImpl<SimpleParallelRDFs()::{lambda()#1}, void>(std::result_of, unsigned int)::{lambda(unsigned int)#1}>::_M_invoke(std::_Any_data const&, unsigned int&&) (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x4AD5362: tbb::interface9::internal::start_for<tbb::blocked_range<unsigned int>, tbb::internal::parallel_for_body<std::function<void (unsigned int)>, unsigned int>, tbb::auto_partitioner const>::execute() (in /home/axel/build/root/24/rel/lib/libImt.so)
==30221==    by 0x670D544: ??? (in /usr/lib/x86_64-linux-gnu/libtbb.so.2)
==30221==    by 0x670D80E: ??? (in /usr/lib/x86_64-linux-gnu/libtbb.so.2)
==30221==    by 0x670AB67: ??? (in /usr/lib/x86_64-linux-gnu/libtbb.so.2)
==30221==    by 0x4AD339E: tbb::interface7::internal::delegated_function<ROOT::TThreadExecutor::ParallelFor(unsigned int, unsigned int, unsigned int, std::function<void (unsigned int)> const&)::{lambda()#1}::operator()() const::{lambda()#1} const, void>::operator()() const (in /home/axel/build/root/24/rel/lib/libImt.so)
==30221==    by 0x6706ED8: tbb::interface7::internal::isolate_within_arena(tbb::interface7::internal::delegate_base&, long) (in /usr/lib/x86_64-linux-gnu/libtbb.so.2)
==30221==    by 0x4AD30F6: tbb::interface7::internal::delegated_function<ROOT::TThreadExecutor::ParallelFor(unsigned int, unsigned int, unsigned int, std::function<void (unsigned int)> const&)::{lambda()#1} const, void>::operator()() const (in /home/axel/build/root/24/rel/lib/libImt.so)
==30221==    by 0x6707E65: tbb::interface7::internal::task_arena_base::internal_execute(tbb::interface7::internal::delegate_base&) const (in /usr/lib/x86_64-linux-gnu/libtbb.so.2)
==30221==    by 0x4AD4917: ROOT::TThreadExecutor::ParallelFor(unsigned int, unsigned int, unsigned int, std::function<void (unsigned int)> const&) (in /home/axel/build/root/24/rel/lib/libImt.so)
==30221==    by 0x153BD2: SimpleParallelRDFs() (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x19B770: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x189F39: testing::Test::Run() [clone .part.0] (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x18A3D1: testing::TestInfo::Run() [clone .part.0] (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x18A5DD: testing::TestSuite::Run() [clone .part.0] (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x18B69C: testing::internal::UnitTestImpl::RunAllTests() (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x18BC07: testing::UnitTest::Run() (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==    by 0x19C4D3: main (in /home/axel/build/root/24/rel/tree/dataframe/test/dataframe_concurrency)
==30221==  Uninitialised value was created by a stack allocation
==30221==    at 0x9D13320: (anonymous namespace)::DAGCombiner::visitOR(llvm::SDNode*) (in /home/axel/build/root/24/rel/lib/libCling.so)
==30221== 

Setup

1. ROOT version: tip of 6-24
2. Operating system: Mint 20.1

[Axel-Naumann]

Confirmed in master / upcoming 6.26.