Patch Version Format has three cyphers #18909
Description
Check duplicate issues.
- Checked for duplicates
Description
Due to #16878
in combination with 4f17792
We get a patch version with three zeroes. I assume this is not much of a problem, but was probably not intended either, since the tip of the branch is now 1, ie 6.36.01.
------------------------------------------------------------------
| Welcome to ROOT 6.36.000 https://root.cern |
| (c) 1995-2025, The ROOT Team; conception: R. Brun, F. Rademakers |
| Built for linuxx8664gcc on May 25 2025, 16:50:46 |
| From tags/v6-36-00@v6-36-00 |
| With c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 |
| Try '.help'/'.?', '.demo', '.license', '.credits', '.quit'/'.q' |
------------------------------------------------------------------
If it would have been 0 instead of 00, that would have not occurred.
My suggestion for solving this is:
either
Writing a GoogleTest that checks that GetVersion().Split()[2] has a length of two if it's a number.
or
add a comment in the RVersion.hxx code saying
// When changing the version number here, never add leading zeroes!
Reproducer
Download 6.36 binary and write:
gROOT->GetVersion()
(const char *) "6.36.000"
ROOT version
------------------------------------------------------------------
| Welcome to ROOT 6.36.000 https://root.cern |
| (c) 1995-2025, The ROOT Team; conception: R. Brun, F. Rademakers |
| Built for linuxx8664gcc on May 25 2025, 16:50:46 |
| From tags/v6-36-00@v6-36-00 |
| With c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 |
| Try '.help'/'.?', '.demo', '.license', '.credits', '.quit'/'.q' |
------------------------------------------------------------------
Installation method
Binary download
Operating system
Ubu22.04
Additional context
No response
Metadata
Metadata
Assignees
Type
Projects
Status