Skip to content

Conversation

ldmi3i
Copy link
Collaborator

@ldmi3i ldmi3i commented Aug 6, 2022

Description

Add base logging interface and implementation based on zap logger. Replace all existing calls to 'fmt/log' with 'logger'.

Closes #21

Current status

  • Waiting for review
  • Waiting for comment resolution
  • Waiting for merge
  • Draft

Semantic Versioning

  • This is a feat change

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated

Unit tests

Manual

Inspecting logs

Checklist:

  • My commit message mentions fix, feat, BREAKING CHANGE accordingly to increase the semantic versioning
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code/docs and corrected any misspellings

@ldmi3i ldmi3i marked this pull request as ready for review August 9, 2022 09:42
@ldmi3i ldmi3i added the review required The pull request is ready and needs to be reviewed or just requesting view from the outside. label Aug 9, 2022
@ldmi3i ldmi3i merged commit 3b80382 into main Aug 13, 2022
@ldmi3i ldmi3i deleted the feature/logger branch August 13, 2022 08:35
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released review required The pull request is ready and needs to be reviewed or just requesting view from the outside.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logger
1 participant