chore: regenerate (update) proto #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
|
Caution Review failedThe pull request is closed. WalkthroughThe Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (70)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR regenerates the protocol buffer files to update the dependency from protoc‑gen‑go v1.34.2 to v1.36.6, ensuring that the auto‑generated code reflects the latest runtime conventions. Key changes include updated version numbers in comments, reorganization of struct field order and tags (including map field tags), and modifications in raw descriptor compression using the unsafe package.
Reviewed Changes
Copilot reviewed 61 out of 73 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/status/v1beta1/status.pb.go | Updated generator version and removal of conditional exporter functions based on UnsafeEnabled. |
| build/service/v1/service.pb.go | Updated generator version and adjusted protobuf tag for map field “Env”. |
| build/google/protobuf/wrappers.pb.go | Updated generator version and modified raw descriptor compression using unsafe.Slice. |
| Other proto files (status, lock, kv, jobs, http, etc.) | Similar version updates and minor reordering of fields consistent with protoc‑gen‑go v1.36.6. |
Files not reviewed (12)
- build/google/protobuf/empty.pb.go: Language not supported
- build/google/api/annotations.pb.go: Language not supported
- build/centrifugo/proxy/v1/proxy_grpc.pb.go: Language not supported
- build/centrifugo/api/v1/api_grpc.pb.go: Language not supported
- build/applogger/v1/applogger.pb.go: Language not supported
- buf.gen.yaml: Language not supported
- build/google/protobuf/timestamp.pb.go: Language not supported
- build/google/protobuf/struct.pb.go: Language not supported
- build/google/protobuf/duration.pb.go: Language not supported
- build/google/protobuf/any.pb.go: Language not supported
- build/google/api/http.pb.go: Language not supported
- build/common/v1/grpc_status.pb.go: Language not supported
Comments suppressed due to low confidence (3)
build/status/v1beta1/status.pb.go:158
- [nitpick] The exporter functions conditioned on 'protoimpl.UnsafeEnabled' have been removed. Please confirm that this change is expected for protoc‑gen‑go v1.36.6 and does not negatively impact performance or debugging.
if !protoimpl.UnsafeEnabled { ... }
build/service/v1/service.pb.go:84
- [nitpick] The removal of ',proto3' from the protobuf key/value tags for the 'Env' map field differs from the previous version. Please verify that this change is intentional and aligns with the updated proto generator requirements.
Env map[string]string `protobuf:"bytes,6,rep,name=env,proto3" json:"env,omitempty" protobuf_key:"bytes,1,opt,name=key" protobuf_val:"bytes,2,opt,name=value"`
build/google/protobuf/wrappers.pb.go:577
- [nitpick] The updated raw descriptor compression now uses 'unsafe.Slice' for constructing the byte slice. Please ensure that this change is compatible with your deployment environment, especially if there are any restrictions on the use of the unsafe package.
file_google_protobuf_wrappers_proto_rawDescData = protoimpl.X.CompressGZIP(unsafe.Slice(unsafe.StringData(file_google_protobuf_wrappers_proto_rawDesc), len(file_google_protobuf_wrappers_proto_rawDesc)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit