Skip to content

Supporting React Native 0.81.0, Updating Project Dependencies, Fixing ESLint and Typescript Warnings and Errors #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Supporting React Native 0.81.0, Updating Project Dependencies, Fixing ESLint and Typescript Warnings and Errors #3941

wants to merge 3 commits into from
+1,032 −1,072

Conversation

whiteHatCip
Copy link
Contributor

@whiteHatCip whiteHatCip commented Aug 24, 2025 •
edited
Loading

Description

This PR contains no functional changes that affect the behavior of this library.

The dependencies and dev dependencies have been updated to their latest version. In addition to that, plenty of chore activities have been implemented, in order to make the library as clean as possible.

Because of the high amount of files changed, I advise you to review this PR using Google Chrome, as it seems that from Safari the Github UI hangs when entering the Files Changed tab
But still, this PR contains ONLY "cosmetic" changes to the code, driven by ESLint and prettier, by simply running yarn lint

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I updated the example app (but no new feature has been implemented)

Changes

  • Adjusted tsconfig settings (noEmit, exclude) to avoid TypeScript errors about overwriting input files.
  • Fixed ESLint warnings (variable shadowing, no-continue and so on) by renaming loop variables and restructuring conditionals and everything else that would prevent ESLint/Typescript from complaining.
  • Some tests were throwing ESLint warnings because the expect invocations are performed from within custom-made functions. These warnings have been fixed by updating the name of jest assert functions in the eslint configuration file.
  • Ran yarn lint:fix after having the prettier plugin restored its functionality, and now prettier errors are properly caught by yarn lint. Because of this, you will see so many files being changed by this PR

@whiteHatCip whiteHatCip mentioned this pull request Aug 24, 2025
Merged
8 tasks
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 24, 2025 19:35 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 24, 2025 19:35 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 24, 2025 19:35 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 24, 2025 19:35 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 24, 2025 19:37 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 24, 2025 19:38 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 24, 2025 19:38 — with GitHub Actions Inactive
This was referenced Aug 25, 2025
Merged
Closed
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 25, 2025 05:59 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 25, 2025 05:59 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 25, 2025 05:59 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 25, 2025 05:59 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 25, 2025 05:59 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 25, 2025 05:59 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 30, 2025 20:26 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip force-pushed the chore/prettier-eslint-typescript-fixes branch from 24e1cc2 to cd213b8 Compare August 31, 2025 23:06
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 31, 2025 23:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 31, 2025 23:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 31, 2025 23:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip had a problem deploying to CI with Mapbox Tokens August 31, 2025 23:06 — with GitHub Actions Failure
@whiteHatCip whiteHatCip had a problem deploying to CI with Mapbox Tokens August 31, 2025 23:06 — with GitHub Actions Failure
@whiteHatCip whiteHatCip had a problem deploying to CI with Mapbox Tokens August 31, 2025 23:06 — with GitHub Actions Failure
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 31, 2025 23:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip force-pushed the chore/prettier-eslint-typescript-fixes branch from cd213b8 to 930ac32 Compare September 1, 2025 18:37
@whiteHatCip whiteHatCip force-pushed the chore/prettier-eslint-typescript-fixes branch from 930ac32 to 3d774d2 Compare September 1, 2025 18:57
@whiteHatCip whiteHatCip self-assigned this Sep 1, 2025
@whiteHatCip whiteHatCip force-pushed the chore/prettier-eslint-typescript-fixes branch 6 times, most recently from fd91f0e to 2bd26df Compare September 3, 2025 02:24
@whiteHatCip whiteHatCip requested a review from mfazekas September 3, 2025 02:41
@whiteHatCip
Updating root dependencies and devDependencies
5d08033 
fixing debounce usage in MapView component in the example app
@whiteHatCip
chore: ESLint and Typescript warnings handling
f6076be 
Fixing eslint warnings in test files

Fixing example app name by lowercasing it

fix(tsconfig): prevent TypeScript from overwriting input files by enabling noEmit

Removing not-needed eslint rule disable comment

Fixing no-continue eslint warnings

Removing unused import

Fixing ESLint warnings in test files

Fixing shadowed vars

Fixing "eqeqeq"

Removing unused vars

Fixing typos

Fixing "'react-native/Libraries/Types/CodegenTypes' React Native deep imports are deprecated." warnings

replacing "import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';" with "import { codegenNativeComponent } from 'react-native';"

This solves a deprecation warning for React Native deep imports, that should use top level import instead

using array and objects destructuring

Removing unused imports and constants

removing unneeded commented code

Suppressing (or fixing) ESLint warnings for explicit-any usages for UnsafeMixed types and others

Updating autogenHelpers files
@whiteHatCip
chore: Prettier
c422e6f 
Restoring prettier functionality and fixing all warnings via yarn lint:fix

Updating prettier to latest version

Updating prettierrc.js rules

making generateCodeWithEjs function an async function, to meet the new requirement from prettier.format which returns a Promise<string> in prettier v3
@whiteHatCip whiteHatCip force-pushed the chore/prettier-eslint-typescript-fixes branch from 2bd26df to c422e6f Compare September 3, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfazekas mfazekas Awaiting requested review from mfazekas

Assignees

@whiteHatCip whiteHatCip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@whiteHatCip