Skip to content

fix: use boolValue for hasPressListener prop #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisforerunner
Copy link

@chrisforerunner chrisforerunner commented Jun 13, 2025

Description

Explicitly extracts the boolValue from the hasPressListener prop on RNMBXVectorSourceComponentView. This fixes an issue when running in New Architecture where all VectorSource layers are marked as touchable because hasPressListener is always true when bridged to Swift.

Functionally, this manifests as a bug wherein VectorSource components will incorrectly "capture" taps, even when no onPress handler is provided, also preventing the root MapView:onPress handler from firing.

Similar change as #3850. Fixes #3864.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

@chrisforerunner
Copy link
Author

Apologies. This looks like a duplicate of #3865. My search skills failed me. I'll leave this open for the maintainers to decide how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MapView onPress doesn't fire through VectorSource Layer
1 participant