Fixed Issue : #3756 ( Mapbox [error] ViewTagResolver) #3852
Conversation
…null found with tag ) It's a fix for this issue : rnmapbox#3756
Med-Li-Jr
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Med-Li-Jr
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
Med-Li-Jr
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Med-Li-Jr
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Med-Li-Jr
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Med-Li-Jr
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Med-Li-Jr
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
| @@ -1171,6 +1171,14 @@ class MapView extends NativeBridgeComponent( | |||
| } | |||
| } | |||
|
|
|||
| if (mapView == null) { | |||
There was a problem hiding this comment.
I don't think that this is good way to solve the issue.
mapView will be null if on layout has not been called yet.
Can't we just add an else to set mapView to an empty fragment instead of null?
if (this.state.isReady) {
...
} else {
mapView = <></>
}
There was a problem hiding this comment.
@Med-Li-Jr code works. @mfazekas your suggestion does not work
There was a problem hiding this comment.
@mfazekas, yeah me too, I didn't think it was a good way to solve it, but it was the only one amongs the things I tried that solved it on my side, I tried the following, but other errors appeared :
-
Attemp 1 :
let mapView = {} as NativeMapViewActual; if (this.state.isReady) { ... } -
Attemp 2 :
let mapView = <RNMBXMapView> </RNMBXMapView>; if (this.state.isReady) { ... } -
Attemp 3 :
let mapView = <></>; if (this.state.isReady) { ... } -
etc....
There was a problem hiding this comment.
@LukasB-DEV, I see, then just changed it on your local code, maybe later, there will be an update that will fix it.
There was a problem hiding this comment.
@Med-Li-Jr is there a code to reproduce the issue? It's not clear in #3756 how to reproduce the issue
There was a problem hiding this comment.
Yes it dont catches everything. Many times same error also comes, but less frequent
There was a problem hiding this comment.
@shahzeb79 , @LukasB-DEV I tried with the init code I don't see the error, Can you share the part of your code that gives the errors ?
There was a problem hiding this comment.
@Med-Li-Jr i face error when lets say i click on icon on map, or state changes on mapscreen. error get triggered but its also random
There was a problem hiding this comment.
@shahzeb79 I see, so that means it's probably a deep error in the project, it may be coming from another file, we'll have to wait for an official resolution😕
|
is there any news on this?? |
|
Any updates? |
Description
Fixes #3756
File Changed : MapView.tsx
Added
your featurethat allows ...Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing