-
-
Notifications
You must be signed in to change notification settings - Fork 904
fix headingindicator bug #3837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix headingindicator bug #3837
Conversation
Thanks for approving @mfazekas - how can I start the pending checks? Or do you have to do it? |
Hit this bug after upgrading to Expo 53 - would be great to see it merged. |
@@ -53,7 +53,7 @@ const normalIcon = ( | |||
style={layerStyles.normal.foreground} | |||
/>, | |||
...(showsUserHeadingIndicator && typeof heading === 'number' | |||
? [HeadingIndicator({ heading, key: 'mapboxUserLocationHeadingIndicator' })] | |||
? [<HeadingIndicator heading={heading} key="mapboxUserLocationHeadingIndicator" />] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I had time to come up with a fix, but for now this solution yields the following error:
"
ERROR Warning: Invariant Violation: Tried to register two views with the same name RNMBXCamera, js engine: hermes
80 | );
81 | };
82 | return <ContextNavigator {...props} wrapper={wrapper}/>;
| ^
83 | }
84 | function AutoStatusBar() {
85 | return <react_native_1.StatusBar barStyle={(0, react_native_1.useColorScheme)() === 'light' ? 'dark-content' : 'light-content'}/>;
Call Stack
ExpoRoot (node_modules/expo-router/build/ExpoRoot.js:82:12)
App (node_modules/expo-router/build/qualified-entry.js:21:7)
ErrorOverlay (node_modules/@expo/metro-runtime/src/error-overlay/index.tsx:19:9)
WithDevTools (node_modules/expo/src/launch/withDevTools.ios.tsx:38:12)
"
Description
Fixes #3826
Checklist
CONTRIBUTING.md
yarn generate
in the root folder/example
app./example
)Minimal fix, tested in own app (Android / iOS, new Arch).