Skip to content

fix headingindicator bug #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cixio
Copy link
Contributor

@cixio cixio commented Apr 13, 2025

Description

Fixes #3826

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Minimal fix, tested in own app (Android / iOS, new Arch).

@cixio cixio temporarily deployed to CI with Mapbox Tokens April 13, 2025 22:13 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens April 13, 2025 22:13 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens April 13, 2025 22:13 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens April 13, 2025 22:13 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens April 13, 2025 22:13 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens April 13, 2025 22:13 — with GitHub Actions Inactive
@cixio cixio temporarily deployed to CI with Mapbox Tokens April 13, 2025 22:13 — with GitHub Actions Inactive
@cixio
Copy link
Contributor Author

cixio commented Apr 26, 2025

Thanks for approving @mfazekas - how can I start the pending checks? Or do you have to do it?

@dwightwatson
Copy link

Hit this bug after upgrading to Expo 53 - would be great to see it merged.

@@ -53,7 +53,7 @@ const normalIcon = (
style={layerStyles.normal.foreground}
/>,
...(showsUserHeadingIndicator && typeof heading === 'number'
? [HeadingIndicator({ heading, key: 'mapboxUserLocationHeadingIndicator' })]
? [<HeadingIndicator heading={heading} key="mapboxUserLocationHeadingIndicator" />]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I had time to come up with a fix, but for now this solution yields the following error:
"
ERROR Warning: Invariant Violation: Tried to register two views with the same name RNMBXCamera, js engine: hermes

80 | );
81 | };

82 | return <ContextNavigator {...props} wrapper={wrapper}/>;
| ^
83 | }
84 | function AutoStatusBar() {
85 | return <react_native_1.StatusBar barStyle={(0, react_native_1.useColorScheme)() === 'light' ? 'dark-content' : 'light-content'}/>;

Call Stack
ExpoRoot (node_modules/expo-router/build/ExpoRoot.js:82:12)
App (node_modules/expo-router/build/qualified-entry.js:21:7)
ErrorOverlay (node_modules/@expo/metro-runtime/src/error-overlay/index.tsx:19:9)
WithDevTools (node_modules/expo/src/launch/withDevTools.ios.tsx:38:12)
"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid prop sourceID supplied to React.Fragment.
4 participants