Use puckBearingEnabled prop in Android #3742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
mfazekas
reviewed
Jan 27, 2025
android/src/main/java/com/rnmapbox/rnmbx/components/location/RNMBXNativeUserLocation.kt
Outdated
Show resolved
Hide resolved
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
force-pushed
the
fix-android-locationpuck-bearing
branch
from
6e60469 to
4c480c7
Compare
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
RmStorm
commented
Jan 27, 2025
Comment on lines
+58
to
+61
| set(value) { | ||
| field = value | ||
| _apply() | ||
| } |
There was a problem hiding this comment.
This is necessary for hot reloading to work on this property.
RmStorm
force-pushed
the
fix-android-locationpuck-bearing
branch
from
4c480c7 to
52ff3f4
Compare
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
RmStorm
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
RmStorm
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
RmStorm
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
mfazekas
reviewed
Feb 24, 2025
| @@ -124,29 +139,45 @@ class RNMBXNativeUserLocation(context: Context) : AbstractMapFeature(context), O | |||
|
|
|||
| private fun _apply(mapView: MapView) { | |||
| val location2 = mapView.location2; | |||
| // Log a warning if both puckBearingEnabled and androidRenderMode are provided | |||
There was a problem hiding this comment.
nitpick: those comments are not needed, the code is easy to understand
Suggested change
| // Log a warning if both puckBearingEnabled and androidRenderMode are provided |
|
@RmStorm can you look into the CI failures, seems to be related to the changes |
mfazekas
approved these changes
Feb 24, 2025
|
@RmStorm Any update here? I’d love to use it in production. |
I'm unlikely to complete this PR since I'm no longer doing app development, someone else should pick up the torch here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3391
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp.yarn generatethrows with a completely unrelated error that I do not have time to debug.