Skip to content

Allow running the test suite with GraphQL::Dataloader #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Sep 24, 2020

I want to keep an eye on what changes are required regarding rmosolgo/graphql-ruby#2483.

TODO:

  • loader_test.rb has a lot of important tests, but doesn't touch GraphQL. Gotta find a way to cover that, too
  • Some hacks were added for instrumentation. Should I upstream those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant