Add support for the riscv64 platform #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade rules_go to v0.59.0 to enable riscv64 platform support Co-authored by: [email protected]; Signed-off-by: ffgan <[email protected]>
|
Contributor
Author
|
Hi @rmohr . Could you please help review this PR? If you have any questions, feel free to @ me directly — I’d be happy to answer anything. |
kellyma2
approved these changes
Nov 19, 2025
Contributor
Author
|
Hi @kellyma2. Thank you for being able to merge this PR. I would like to ask if you could consider releasing a new version? I am very much looking forward to having a usable bazeldnf for riscv64. Thanks again for the maintainers' hard work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Recently, riscv64 has gained widespread adoption, so we might consider adding support for it. I recently submitted a relatively simple PR to rules_go, which allows it to support riscv64 to some extent—upgrading to v0.59.0 is sufficient to enable this.
I ran the CI in my fork, and everything went smoothly. The results are as follows:
Since I couldn’t find existing tests for architectures other than amd64 and arm64, I haven’t added any riscv64-specific tests for now. I believe this PR should work fine on riscv64 as well.
Technically, we could run tests for other architectures using a qemu + docker setup, but that would also require building Bazel for the corresponding architecture in advance. Those steps are outside the scope of this PR, but if needed, I can open a separate PR to implement that.
if any maintainers have questions, feel free to @ me — I’d be happy to answer any related questions.
Other Info
Co-authored by: [email protected];
Co-authored by: [email protected];