-
Notifications
You must be signed in to change notification settings - Fork 320
Backport 2020.06 for torch support 1.7 #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjulian
reviewed
Aug 19, 2020
acd2220
to
9dc3f51
Compare
@Mergifyio rebase |
Command
|
9dc3f51
to
fe07d4f
Compare
ryanjulian
reviewed
Aug 19, 2020
fe07d4f
to
497f511
Compare
ryanjulian
approved these changes
Aug 19, 2020
yeukfu
approved these changes
Aug 19, 2020
@Mergifyio rebase |
Command
|
497f511
to
3650c31
Compare
If we are backporting support for torch 1.6, we should also allow torch 1.6 in setup.py, right? Currently it is set to <1.5.0 |
3650c31
to
336bbb9
Compare
backport #1899
336bbb9
to
7e2af6c
Compare
Stuck on #1940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #1823 (Backport 2020.06): torch.full with no argument dtype due to torch 1.7 no longer support 1.6 version.