Skip to content

Backport 2020.06 for torch support 1.7 #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

irisliucy
Copy link
Contributor

This PR fix #1823 (Backport 2020.06): torch.full with no argument dtype due to torch 1.7 no longer support 1.6 version.

@irisliucy irisliucy requested a review from a team as a code owner August 18, 2020 23:55
@irisliucy irisliucy requested review from ahtsan, a team and gitanshu and removed request for a team August 18, 2020 23:55
@mergify mergify bot requested review from a team and yeukfu and removed request for a team August 18, 2020 23:55
@irisliucy irisliucy force-pushed the update-torch-1.6-support branch from acd2220 to 9dc3f51 Compare August 19, 2020 00:51
@gitanshu
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Command rebase: success

Branch has been successfully rebased

@ahtsan ahtsan force-pushed the update-torch-1.6-support branch from 9dc3f51 to fe07d4f Compare August 19, 2020 01:51
@irisliucy irisliucy force-pushed the update-torch-1.6-support branch from fe07d4f to 497f511 Compare August 19, 2020 20:08
@irisliucy irisliucy linked an issue Aug 19, 2020 that may be closed by this pull request
@mergify mergify bot requested a review from a team August 19, 2020 21:57
@gitanshu
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Command rebase: success

Branch has been successfully rebased

@ahtsan ahtsan force-pushed the update-torch-1.6-support branch from 497f511 to 3650c31 Compare August 19, 2020 22:33
@gitanshu
Copy link
Contributor

If we are backporting support for torch 1.6, we should also allow torch 1.6 in setup.py, right? Currently it is set to <1.5.0

@gitanshu gitanshu force-pushed the update-torch-1.6-support branch from 3650c31 to 336bbb9 Compare August 19, 2020 23:29
@gitanshu gitanshu force-pushed the update-torch-1.6-support branch from 336bbb9 to 7e2af6c Compare August 20, 2020 08:19
@gitanshu
Copy link
Contributor

Stuck on #1940

@ryanjulian ryanjulian merged commit 7e69176 into release-2020.06 Aug 20, 2020
@ryanjulian ryanjulian deleted the update-torch-1.6-support branch August 20, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Torch 1.6.0 incompatibility
4 participants