fix: update verl import paths for verl 0.7.1+ compatibility#480
Merged
Conversation
verl 0.7.1 refactored fully_async_policy.ray_trainer into separation.ray_trainer (PR verl-project/verl#5184). Update imports: - FullyAsyncRayPPOTrainer → SeparateRayPPOTrainer - FullyAsyncAgentLoopManager → AgentLoopManager - fully_async_policy.fully_async_main → separation.utils Fixes rllm-org#470 Signed-off-by: Lidang-Jiang <lidangjiang@gmail.com>
Signed-off-by: Lidang-Jiang <lidangjiang@gmail.com>
Collaborator
|
Thanks for catching this! We have plans to integrate fully async into the verl backend of the unified trainer, but this is a needed fix in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verl 0.7.1 refactored
fully_async_policy.ray_trainerintoseparation.ray_trainer(verl-project/verl#5184), breaking imports inrllm/experimental/fully_async/.Updated 3 files:
FullyAsyncRayPPOTrainer→SeparateRayPPOTrainer(fromverl.experimental.separation.ray_trainer)FullyAsyncAgentLoopManager→AgentLoopManager(fromverl.experimental.agent_loop)fully_async_policy.fully_async_main→separation.utils(forcreate_resource_pool_manager)Fixes #470
Before
After
Import paths updated to match verl 0.7.1+ module structure:
verl.experimental.fully_async_policy.ray_trainer→verl.experimental.separation.ray_trainerverl.experimental.fully_async_policy.agent_loop.FullyAsyncAgentLoopManager→verl.experimental.agent_loop.AgentLoopManagerverl.experimental.fully_async_policy.fully_async_main→verl.experimental.separation.utilsAll updated paths verified to exist in verl main branch.
Test plan