WEB3-499: chore: upgrade alloy-evm
#643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
alloy-evmalloy-evm
This was referenced Jul 17, 2025
nategraf
approved these changes
Jul 28, 2025
Comment on lines
+176
to
+196
| let blob_excess_gas_and_price = | ||
| header | ||
| .excess_blob_gas | ||
| .map(|excess_blob_gas| match spec.into_eth_spec() { | ||
| SpecId::CANCUN => BlobExcessGasAndPrice::new( | ||
| excess_blob_gas, | ||
| eip4844::BLOB_GASPRICE_UPDATE_FRACTION as u64, | ||
| ), | ||
| SpecId::PRAGUE => BlobExcessGasAndPrice::new( | ||
| excess_blob_gas, | ||
| eip7691::BLOB_GASPRICE_UPDATE_FRACTION_PECTRA as u64, | ||
| ), | ||
| SpecId::OSAKA => BlobExcessGasAndPrice::new( | ||
| excess_blob_gas, | ||
| eip7691::BLOB_GASPRICE_UPDATE_FRACTION_PECTRA as u64, | ||
| ), | ||
| _ => unimplemented!( | ||
| "unsupported spec with `excess_blob_gas`: {}", | ||
| <&'static str>::from(spec) | ||
| ), | ||
| }); |
There was a problem hiding this comment.
I ran into this with a bit of my work. Can we have a public utility function for this, or do you think that would be a bad idea?
There was a problem hiding this comment.
There actually is https://docs.rs/alloy-eips/1.0.23/alloy_eips/eip7840/struct.BlobParams.html#method.calc_blob_fee which exactly does that.
Probably, eventually when this gets more complicated we should add https://docs.rs/alloy-eips/1.0.23/alloy_eips/eip7892/struct.BlobScheduleBlobParams.html to our config. But I tried to avoid this at this level because it would be a breaking change effecting config IDs and such.
capossele
pushed a commit
that referenced
this pull request
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.