Support older Python 2.7 versions #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2.7.2 and 2.7.3 struct.unpack() fail with:
error: unpack requires a string argument of length 4
Due to bytearray parameter. Casting as bytes() works for both Python 2.7.x and 3.x.
http://stackoverflow.com/questions/20612587/struct-unpack-with-bytearrays has more information
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2.7.2 and 2.7.3 struct.unpack() fail with:
If key is passed in as a bytearray parameter, this is fine in later 2.7.x versions and Python 3.x. Casting as bytes() works for both Python 2.7.x and 3.x.
http://stackoverflow.com/questions/20612587/struct-unpack-with-bytearrays has more information