probe: raw_tp: fix cookie support detection #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookie support in raw tracepoints was done looking at if the bpf_get_attach_cookie_tracing type existed, but this[1] actually precede the introduction of the raw tp cookie support. Fix this by also checking if the cookie field exist in the bpf_raw_tp_link struct instead, which was introduced as part of the raw tp cookie support[2]. Fixes #560. [1] 2fcc82411e74 ("bpf, x86: Attach a cookie to fentry/fexit/fmod_ret/lsm."). [2] 68ca5d4eebb8 ("bpf: support BPF cookie in raw tracepoint (raw_tp, tp_btf) programs"). Fixes: d55a7f7 ("core: probe: kernel: set the symbol address in the BPF cookie"). Signed-off-by: Antoine Tenart <[email protected]>
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 37.24% 37.23% -0.02%
==========================================
Files 104 104
Lines 10812 10816 +4
Branches 10812 10816 +4
==========================================
Hits 4027 4027
- Misses 6482 6486 +4
Partials 303 303
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookie support in raw tracepoints was done looking at if the bpf_get_attach_cookie_tracing type existed, but this[1] actually precede the introduction of the raw tp cookie support. Fix this by also checking if the cookie field exist in the bpf_raw_tp_link struct instead, which was introduced as part of the raw tp cookie support[2].
Fixes #560.
[1] 2fcc82411e74 ("bpf, x86: Attach a cookie to fentry/fexit/fmod_ret/lsm."). [2] 68ca5d4eebb8 ("bpf: support BPF cookie in raw tracepoint (raw_tp, tp_btf)
programs").
Fixes: d55a7f7 ("core: probe: kernel: set the symbol address in the BPF cookie").