Add missing docstring for String #7571
Conversation
runtime/Stdlib_String.res
Outdated
| @@ -1,6 +1,6 @@ | |||
| type t = string | |||
|
|
|||
| @val external make: 'a => string = "String" | |||
| @new external make: 'a => string = "String" | |||
There was a problem hiding this comment.
I don't think we should do that, see:
There was a problem hiding this comment.
Yeah, that sounds right, but how does setSymbol work then?
There was a problem hiding this comment.
Sadly, it won't. Seems will only work on string object instances.
So the binding is incorrect IMHO. We'd need another abstract type for string object instances, and could then define getSymbol/setSymbol on that.
I assume this is a pretty niche use case anyway. Personally I never tried setting a value with a symbol key on a string before. Maybe we should just remove the getSymbol/setSymbol bindings from the stdlib?
There was a problem hiding this comment.
Maybe we should just remove the getSymbol/setSymbol bindings from the stdlib?
Yes, I think that makes more sense.
This one is a bit weird, I had to make the
@valto@newchange to make the examples work.I noticed this in plain JavaScript as well, that not having the
newkeyword, doesn't make it work.Happy to hear your thoughts here, not sure what is best.