Skip to content

Fix floatcomp for %max #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristianoc merged 5 commits into from
Mar 13, 2025
Merged

Fix floatcomp for %max #7333

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69a21e0
Fix floatcomp for %max
JonoPrest Mar 12, 2025
260b462
Update mario_game generated test code
JonoPrest Mar 12, 2025
f666e6f
Update changelog
JonoPrest Mar 12, 2025
ba80b11
Fix second case of floatcomp mapped to Pboolmax
JonoPrest Mar 12, 2025
9694b90
Fix %bs_min and %bs_max comparison
JonoPrest Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/ml/translcore.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ let comparisons_table =
objcomp = Pobjmax;
intcomp = Pintmax;
boolcomp = Pboolmax;
floatcomp = Pboolmax;
floatcomp = Pfloatmax;
stringcomp = Pstringmax;
bigintcomp = Pbigintmax;
simplify_constant_constructor = false;
Expand Down
Loading