Skip to content

Bundle stdlib runtime for playground #7255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhammerschmidt merged 2 commits into from
Jan 25, 2025
Merged

Bundle stdlib runtime for playground #7255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
350af7c
bundle stdlib JS files for playground
tsnobip Jan 25, 2025
5af9419
stop uncapitalizing js files in playground imports
tsnobip Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/core/js_name_of_module_id.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ let string_of_module_id_in_browser (x : Lam_module_ident.t) =
match x.kind with
| External {name} -> name
| Runtime | Ml ->
"./stdlib/" ^ Ext_string.uncapitalize_ascii x.id.name ^ ".js"
"./stdlib/" ^ x.id.name ^ ".js"
Copy link
Member

@fhammerschmidt fhammerschmidt Jan 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this can go away for both Ml and Runtime?

Copy link
Member Author

@tsnobip tsnobip Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only used in the playground so it should be safe. It was invalid before.


let string_of_module_id
(id : Lam_module_ident.t)
Expand Down
Loading
Loading