Skip to content

Restored belt Ok and Error constructors #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Restored belt Ok and Error constructors #6514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d0324
Restored belt Ok and Error constructors
TheSpyder Dec 7, 2023
d9a79e8
Add PR URL to changelog
TheSpyder Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

# 11.0.0-rc.8 (Unreleased)

#### :bug: Bug Fix

- Fix accidental removal of `Belt.Result.Ok` and `Belt.Result.Error` constructors in rc.5 https://github.com/rescript-lang/rescript-compiler/pull/6514

# 11.0.0-rc.7

#### :rocket: New Feature
Expand Down
4 changes: 3 additions & 1 deletion jscomp/others/belt_Result.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */

type t<'a, 'b> = result<'a, 'b>
type t<'a, 'b> = result<'a, 'b> =
| Ok('a)
| Error('b)

let getExn = x =>
switch x {
Expand Down
4 changes: 3 additions & 1 deletion jscomp/others/belt_Result.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
This module gives you useful utilities to create and combine `Result` data.
*/

type t<'a, 'b> = result<'a, 'b>
type t<'a, 'b> = result<'a, 'b> =
| Ok('a)
| Error('b)

/**
`getExn(res)`: when `res` is `Ok(n)`, returns `n` when `res` is `Error(m)`, raise an exception
Expand Down