Fix dependency on Js_obj in Jsx module #5669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another feature, I got a build error on Windows CI:
The problem is that
jsx.ml
usesJs.Obj.assign
, but the dependency on theJs_obj
module is not added to the ninja file.As a workaround, I changed
Js.Obj.assign
toJs_obj.assign
which caused the dependency to be picked up correctly.