Skip to content

Fix dependency on Js_obj in Jsx module #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 18, 2022

While working on another feature, I got a build error on Windows CI:

rescript: [86/988] others/jsx.cmi
FAILED: others/jsx.cmi
D:\a\rescript-compiler\rescript-compiler\win32\bsc.exe -bs-cmi -bs-cmj -no-keep-locs -no-alias-deps -bs-no-version-header -bs-no-check-div-by-zero -nostdlib  -bs-cross-module-opt -make-runtime   -nopervasives  -unsafe  -w +50 -warn-error A -open Belt_internals   -I others  others/jsx.ml
File "others/jsx.ml", line 42, characters 14-27:
Error: The module Js.Obj is an alias for module Js_obj, which is missing

The problem is that jsx.ml uses Js.Obj.assign, but the dependency on the Js_obj module is not added to the ninja file.

As a workaround, I changed Js.Obj.assign to Js_obj.assign which caused the dependency to be picked up correctly.

@cristianoc cristianoc merged commit bdab0b6 into rescript-lang:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants