int array -> Int32Array, bytes -> UInt8Array, float array -> Float64Array

[bobzhang]

reminder.

int array, float array -- should be easy (with a command line flag?)
bytes -- need to checking lexing runtime support

[bobzhang]

same for floatArray.

there is a caveat for FloatArray.map -- in the standard api, you can not change its type

[bobzhang]

since typedarray is an essential feature, maybe we should have a flag -bs-use-typed-array, but how does it work for some modules compiled using such flag while others not?

[TheSpyder]

@bobzhang is this anywhere on the current roadmap? It has been idle for quite a few years now.

I'm considering using ocaml-protoc (which has BuckleScript support) but the representation of bytes as a number array instead of UInt8Array is not going to work.

[bobzhang]

it’s slow but it should work? Andrew Herron <notifications@github.com>于2020年6月9日 周二下午12:29写道：

@bobzhang <https://github.com/bobzhang> is this anywhere on the current roadmap? It has been idle for quite a few years now. I'm considering using ocaml-protoc <https://github.com/mransan/ocaml-protoc> (which has BuckleScript support) but the representation of bytes as a number array instead of UInt8Array is not going to work. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFWMK5NE7S7DLUS6BAZWLLRVW3CFANCNFSM4CBEAOEQ> .

-- Regards -- Hongbo Zhang

[TheSpyder]

I guess "works" isn't the word I meant. I'm sure it meets the requirements, or it wouldn't be in the codebase, but slow isn't an option for me.

[chenglou]

but slow isn't an option for me.

Need more of such spirit around =D

[TheSpyder]

@chenglou I am aiming to blow some socks off when I finally release what I've been working on 😂

To be more specific about why slow isn't an option, protobuf uses byte arrays for the messages. It needs to serialize, deserialize, encode and decode to and from them constantly.

I'm using protobuf-js and some custom bindings to UInt8Array at the moment, but it would be nice to have auto-generated bindings with ocaml-protoc. That may also save some of the bundle size protobuf-js brings along for the ride.

[bobzhang]

Note bytes does not need special treatment from the compiler. For your use case, you can use your own module for UInt8Array. We are open minded to replace bytes module's implementation with a new one on top of UInt8Array, notably changing `stdlib-406/bytes.ml`, are you interested in sending a PR?

…

On Fri, Jun 26, 2020 at 1:55 PM Andrew Herron ***@***.***> wrote: @chenglou <https://github.com/chenglou> I am aiming to blow some socks off when I finally release what I've been working on 😂 To be more specific about why slow isn't an option, protobuf uses byte arrays for the messages. It needs to serialize, deserialize, encode and decode to and from them *constantly*. I'm using protobuf-js and some custom bindings to UInt8Array at the moment, but it would be nice to have auto-generated bindings with ocaml-protoc. That may also save some of the bundle size protobuf-js brings along for the ride. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFWMKYIPFFX6NTI5UX2QE3RYQZ3PANCNFSM4CBEAOEQ> .

-- Regards -- Hongbo Zhang

[TheSpyder]

I'm not sure what you mean by For your use case, you can use your own module for UInt8Array. 🤔

I admit I haven't actually tried to use ocaml-protoc yet, this was just a flag that came up in our task to investigate it. I might start compiling it with BuckleScript and hit some other blocker. I'm scheduled to look at that in more detail in a month or so, if it looks like the way we want to go then yes I can try to make a PR.

I assume there's more to this than changing the bytes.ml implementation? Wouldn't the underlying bytes type and the %bytes_ externals need to change too?