Enable incremental typechecking by default #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, let's enable project cache config too by default. Updating the PR. |
|
I never tested the project cache config apparently. Is it stable enough to activate by default already? |
|
I think so. But it'd be good to give it a spin in your project(s) too of course. |
cristianoc
approved these changes
Oct 24, 2024
|
I mean that's why we have pre-releases anyway, right? Or do you want to release this as stable soon? |
fhammerschmidt
approved these changes
Oct 24, 2024
|
We can do pre-release for a while, sure. Maybe a week or so. But then the big benefit comes from shipping this to stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables incremental typechecking by default by changing the name of the prop (so old configs are invalidated) and setting a new default.
I'm sure there are more things we could do with incremental typechecking to make it a better experience, but at this point it's such a magnitudes better experience even with the small issues it might have. Enabling by default will make the experience better for everyone by default, and if issues surface we can fix them.
This also enables the
projectConfigcache options, that dramatically reduce latency in certain scenarios.