Add from_gray16 for DepthImage - #8213
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
Wumpf
self-requested a review
November 25, 2024 09:05
Wumpf
requested changes
Nov 25, 2024
Wumpf
left a comment
Wumpf
left a comment
Member
There was a problem hiding this comment.
thanks for contributing! Looks good to me, but would be nice to make use of that in something that is tested from CI.
Doesn't need to be fancy, just compare outcome of from_gray16 with using try_from. You could for instance the snippet from depth_image_simple and check that it constructs the depth image the same way when built with from_gray16 or from_data_type_and_bytes. Test can as a separate test function to crates/store/re_types/tests/types/depth_image.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depth image are usually stored in a 16-bit gray format. This pr is used to simplify this step