Skip to content

Conversation

@viceice
Copy link
Member

@viceice viceice commented Dec 15, 2025

Changes

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@viceice viceice requested a review from jamietanna December 15, 2025 10:12
@jamietanna jamietanna changed the title chore: update vite to v8 chore(deps): update vite to v8 Dec 15, 2025
Copy link
Contributor

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we happy staying on beta releases for now? I'm happy if you are

Do we know when v8 will officially land?

@viceice
Copy link
Member Author

viceice commented Dec 16, 2025

Are we happy staying on beta releases for now? I'm happy if you are

Do we know when v8 will officially land?

It's a dev only dependency, so i think it's ok to be on a pre-release for vite to fix our issue

jamietanna
jamietanna previously approved these changes Dec 16, 2025
@viceice
Copy link
Member Author

viceice commented Dec 16, 2025

rebased to resolve conflict

@viceice viceice enabled auto-merge December 16, 2025 10:41
@jamietanna
Copy link
Contributor

Looks like there's already another 🫣

@viceice viceice added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit da6234d Dec 16, 2025
41 checks passed
@viceice viceice deleted the chore/vite-v8 branch December 16, 2025 11:11
@github-actions
Copy link
Contributor

🎉 This PR is included in version 42.58.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants