-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(jsonata): updates when version and digest changed (#36461) #38066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This ensures an update with both an newValue and a newDigest is accepted by renovate (before only one of them worked, if both were updated it would fail).
Also do `replaceWithoutReplaceString` if `replaceString` is missing and more than one value changed (e.g. `digest` and `version`). See renovatebot#36461 and the regression test.
Hi there, You are using Good luck, The Renovate team |
🎉 This PR is included in version 41.119.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We are basing it on the fact that when only |
Did it cause a regression? I don't know if both |
In my tests only |
No such cases as of now. I am just trying to understand the thinking behind the change |
Originally, if E.g
This doesn't work for the
It will then perform the update with The code changes the logic so it doesn't set the
This reuses the codepath that was used to update the |
Sounds good |
Changes
auto-replace
to consider the number of changes to be made.If more than one change needs to be made and
replaceString
is not set then also setreplaceWithoutReplaceString
.Context
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: