-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(managers): add Deno manager support #37828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Base branch is: main Base branch ref for this PR is: c3a9360 ✅ Snapshot code check passed. Added files in '__fixtures__': lib/modules/manager/deno/__fixtures__/.gitignore lib/modules/manager/deno/__fixtures__/npm-compat-workspace/deno.lock lib/modules/manager/deno/__fixtures__/npm-compat-workspace/package.json lib/modules/manager/deno/__fixtures__/npm-compat-workspace/sub/package.json lib/modules/manager/deno/__fixtures__/workspace-01/deno.json lib/modules/manager/deno/__fixtures__/workspace-01/deno.lock lib/modules/manager/deno/__fixtures__/workspace-01/docs/deno.json lib/modules/manager/deno/__fixtures__/workspace-01/docs/deno.lock lib/modules/manager/deno/__fixtures__/workspace-01/packages/pkg1/deno.jsonc lib/modules/manager/deno/__fixtures__/workspace-01/packages/pkg1/deno.lock lib/modules/manager/deno/__fixtures__/workspace-02/deno.json lib/modules/manager/deno/__fixtures__/workspace-02/deno.lock lib/modules/manager/deno/__fixtures__/workspace-02/docs/deno.json lib/modules/manager/deno/__fixtures__/workspace-02/import_map.json lib/modules/manager/deno/__fixtures__/workspace-03/deno.json lib/modules/manager/deno/__fixtures__/workspace-03/deno.lock lib/modules/manager/deno/__fixtures__/workspace-03/node/package.json Total number of added files in '__fixtures__': 17 Deleted files in '__fixtures__': Total number of deleted files in '__fixtures__': 0 Updated total number of added files in '__fixtures__': 17 Updated total number of deleted files in '__fixtures__': 0 ❌ Error: More files have been added to '__fixtures__' directories than deleted. Error: Process completed with exit code 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Let's have JSR datasource and Deno manager as separate PRs.
@zharinov |
Hi there, Please don't merge from Thanks, The Renovate team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement schema.ts
without resorting to vibe-coding
Changes
Closes #6237
needs #37881
This PR adds deno manager.
Additionally, deno manager also supports
package.json
for their node-compat.The Deno CLI itself supports private registries that are compatible with npm registries by reading
.npmrc
.However, this PR does not implement such support due to I was concerned that the PR would become too large, which is possible by referencing the code of existing npm managers.
I think that the current implementation covers most use cases, and that it will be sufficient to add support for private npm registries later, while addressing any issues that arise in real-world repositories after this PR is shipped.
I will add Deno to Containerbase later.
Context
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
I received assistance from AI in various aspects of submitting this PR.
I found it particularly useful in being able to write complex regular expressions and what to do with markdown links in mkdoc.
It also provided advice and code generation on performance optimization, mainly after the code I wrote had passed unit tests.
Therefore, I think of it mainly as acting as a rubber duck and support for the code I wrote.
On the other hand, Renovate's code is quite complex, and I found it difficult to build features from scratch because it would be difficult to reduce the context size.
The tools I used were GitHub Copilot Agent, DeepWiki, and Google Gemini, and the models were Claude Sonnet4 and Gemini 2.5 Pro.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: https://github.com/Hajime-san/renovate-test3