feat(npm): support yarn catalogs via yarn-plugin-catalogs #37293
+1,435
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKruschke
commented
Aug 3, 2025
viceice
reviewed
Aug 4, 2025
6 tasks
viceice
reviewed
Sep 15, 2025
viceice
reviewed
Sep 19, 2025
12 tasks
viceice
reviewed
Sep 19, 2025
| getSiblingFileName, | ||
| readLocalFile, | ||
| } from '../../../../util/fs'; | ||
| import { ensureLocalPath } from '../../../../util/fs/util'; |
There was a problem hiding this comment.
Suggested change
| import { ensureLocalPath } from '../../../../util/fs/util'; |
wrong import path anyways
Co-authored-by: Michael Kriese <[email protected]>
viceice
reviewed
Sep 19, 2025
RahulGautamSingh
suggested changes
Sep 20, 2025
| const res = await npmExtract.extractPackageFile( | ||
| pJsonStr, | ||
| 'package.json', | ||
| '.yarnrc.yml', |
There was a problem hiding this comment.
Why this change?
There was a problem hiding this comment.
good spot I changed one test to much after the refactoring. Will revert it
| catalogs: YarnCatalogs | undefined, | ||
| packageFile: string, | ||
| hasPackageManager: boolean, | ||
| ): Promise<PackageFileContent<NpmManagerData> | null> { |
There was a problem hiding this comment.
when is null being returned?
There was a problem hiding this comment.
nice catch implementation changed and now it isn't returning it any more
Co-authored-by: RahulGautamSingh <[email protected]>
Co-authored-by: RahulGautamSingh <[email protected]>
viceice
approved these changes
Sep 21, 2025
RahulGautamSingh
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Support
catalogsfor yarn via the plugin yarn-plugin-catalogs. See short discussion -> #36928Note: informed the plugin authors -> toss/yarn-plugin-catalogs#19
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: