feat(config): templateStrings #35662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
changed the title
rarkins
changed the title
viceice
reviewed
May 4, 2025
| } | ||
| let writeLocation = this.migratedConfig; | ||
| const keySplits = key.split('.'); | ||
| if (keySplits.length === 2) { |
There was a problem hiding this comment.
should we log a warning when length is greater than 2?
|
|
||
| - Change the entire layout/flow by using `prBodyTemplate` (we do not recommend this) | ||
| - Change the entire layout/flow by using `stringTemplates.prBody` (we do not recommend this) | ||
| - Add a header by using `prHeader` |
| prFooter?: string; | ||
| prBodyNotes?: string[]; | ||
| prBodyTemplate?: string; | ||
| templateStrings?: Record<string, string>; |
There was a problem hiding this comment.
we should later add known keys for better typo type check.
|
why closed? |
|
I don't have time to finish it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds new config object
templateStrings.Context
Closes #35663
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: