-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: interactive reconfigure pr #34696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remaining - pr - comment - refactoring - validation of cache purity - tests - reconfigureCache setting and deletion
# Pull Request ## 🤨 Rationale #2557 ## 👩💻 Implementation Add a configuration for npm dependencies starting with `@ni/` to update immediately. This should include the FAST forks and javascript-styleguide packages. ## 🧪 Testing I was hoping Renovate would ping this PR to let us know what it'll do but I don't think that's how it works ([yet](renovatebot/renovate#34696)). I'll see what PR it creates after I complete this PR. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Milan Raj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has conflicts else LGTM
|
This has been approved for a while. Needs attention :) |
|
🎉 This PR is included in version 40.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Is there any documentation associated with this change which describes how to use the feature? Eager to try it out, but it's not clear how to trigger it. Does the PR need to be named something specific? Will it detect simply based on the renovate file changing? Does any configuration change need to be made to enable the feature? |
This section here is dedicated to reconfigration. It needs an update though, I will do it soon. For you case:
Any feedback which helps you understand the changes better, are welcome. Thanks! Answer to you question
|
|
Is it already live? |
|
@LecrisUT at the time you asked, this merge was 15 minutes old so Renovate hadn't even completed publishing a new version yet. Then assuming you are referring to the Mend-hosted app, it never goes immediately live. Upgrades are done typically twice a week and monitored. |
Perfect, thanks @RahulGautamSingh! Something like that would be immensely useful in the docs I suspect 😉 |
Changes
mergeRenovateConfigfn such that it can pass the branchName to thedetectConfigFilefn which comes in handy when trying to read the config file from reconfigure branch using api endpointContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: