Skip to content

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Mar 8, 2025

Changes

  • check if reconfigure pr exists
  • if reconfigure pr found, add a comment on the pr with expected pr's list and config description
  • expand reconfigure cache to store extraction result so we can skip processing the reconfigure branch if it has not changed
  • make slight changes mergeRenovateConfig fn such that it can pass the branchName to the detectConfigFile fn which comes in handy when trying to read the config file from reconfigure branch using api endpoint
  • added tests

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required (todo)

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
  1. reconf pr Rahul-renovate-testing/recon-pr#1
  2. Reconfigure PR Rahul-renovate-testing/repro-10869-new#6

@RahulGautamSingh RahulGautamSingh marked this pull request as draft March 8, 2025 05:54
rajsite added a commit to ni/nimble that referenced this pull request Mar 20, 2025
# Pull Request

## 🤨 Rationale

#2557 

## 👩‍💻 Implementation

Add a configuration for npm dependencies starting with `@ni/` to update
immediately. This should include the FAST forks and
javascript-styleguide packages.

## 🧪 Testing

I was hoping Renovate would ping this PR to let us know what it'll do
but I don't think that's how it works
([yet](renovatebot/renovate#34696)). I'll see
what PR it creates after I complete this PR.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
@RahulGautamSingh RahulGautamSingh changed the title feat: interative reconfigure pr feat: interactive reconfigure pr Mar 29, 2025
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review March 29, 2025 07:49
@RahulGautamSingh RahulGautamSingh mentioned this pull request Apr 22, 2025
6 tasks
@RahulGautamSingh RahulGautamSingh requested a review from secustor May 4, 2025 19:47
RahulGautamSingh added a commit to RahulGautamSingh/renovate that referenced this pull request May 15, 2025
viceice
viceice previously approved these changes Jun 4, 2025
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has conflicts else LGTM

@RahulGautamSingh
Copy link
Collaborator Author

This has been approved for a while. Needs attention :)

@secustor secustor added this pull request to the merge queue Jun 15, 2025
Merged via the queue into renovatebot:main with commit 326cfb5 Jun 15, 2025
40 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 40.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ben-foxmoore
Copy link

Is there any documentation associated with this change which describes how to use the feature? Eager to try it out, but it's not clear how to trigger it. Does the PR need to be named something specific? Will it detect simply based on the renovate file changing? Does any configuration change need to be made to enable the feature?

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jun 16, 2025

Is there any documentation associated with this change which describes how to use the feature? Eager to try it out, but it's not clear how to trigger it. Does the PR need to be named something specific? Will it detect simply based on the renovate file changing? Does any configuration change need to be made to enable the feature?

This section here is dedicated to reconfigration. It needs an update though, I will do it soon.

For you case:

  1. Create a new renovate/reconfigure branch
  2. Make edits to the renovate.json file as per your needs
  3. Create a PR using that branch
  4. Run renovate locally (if self-hosted) or wait for hosted Renovate app to add a comment to your PR explaining the expected outcome from the new config.

Any feedback which helps you understand the changes better, are welcome. Thanks!

Answer to you question

Does the PR need to be named something specific?
No.

Will it detect simply based on the renovate file changing?
Yes.

Does any configuration change need to be made to enable the feature?
No.

@LecrisUT
Copy link

Is it already live?

@rarkins
Copy link
Contributor

rarkins commented Jun 16, 2025

@LecrisUT at the time you asked, this merge was 15 minutes old so Renovate hadn't even completed publishing a new version yet.

Then assuming you are referring to the Mend-hosted app, it never goes immediately live. Upgrades are done typically twice a week and monitored.

@ben-foxmoore
Copy link

Is there any documentation associated with this change which describes how to use the feature? Eager to try it out, but it's not clear how to trigger it. Does the PR need to be named something specific? Will it detect simply based on the renovate file changing? Does any configuration change need to be made to enable the feature?

This section here is dedicated to reconfigration. It needs an update though, I will do it soon.

For you case:

  1. Create a new renovate/reconfigure branch
  2. Make edits to the renovate.json file as per your needs
  3. Create a PR using that branch
  4. Run renovate locally (if self-hosted) or wait for hosted Renovate app to add a comment to your PR explaining the expected outcome from the new config.

Any feedback which helps you understand the changes better, are welcome. Thanks!

Answer to you question

Perfect, thanks @RahulGautamSingh! Something like that would be immensely useful in the docs I suspect 😉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive Reconfigure PR
8 participants