feat(github-actions): Support for short tag comments

[zharinov]

Changes

Context

• Closes: Support "short" GitHub Actions tag comments #18640

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[zharinov]

Test: https://github.com/renovate-testing/test-18640-github-actions-short-names

[viceice]

Otherwise LGTM

[rarkins]

What affect does this have on when we "pin" actions to a digest? Do we still use tag= in that case?

[zharinov]

I'm not sure what do you mean, for me this PR just extends the syntax we're able to parse.

[rarkins]

We have functionality to convert from tag-only to sha + tag comment, when pinDigests=true

[zharinov]

Okay, here is example:

• https://github.com/renovate-testing/test-18640-github-actions-short-names/pull/5/files
• https://github.com/renovate-testing/test-18640-github-actions-short-names/pull/6/files

[viceice]

otherwise LGTM

[renovate-release]

🎉 This PR is included in version 34.18.0 🎉

The release is available on:

• GitHub release
• 34.18.0

Your semantic-release bot 📦🚀

[Gabriel-Ladzaretti]

@viceice @zharinov
i ran this againt the full dependabot yaml file, is the short sha to semver update the expected behavior?

EDIT: also note that line 16 (short sha) is expended into full sha

[Gabriel-Ladzaretti]

ok so i ran this with an older version of renovate

so this is not related to this one, but still is this expected 🙃:?

looking at line 16, it looks like it does 🤔 (?)

[zharinov]

Tell me what's expected, I'll fix

[viceice]

• line 16 is wrong, it should update to long sha and not to short version. best to even not touch at all if sha is same
• line 19 seems to be wrong. the comment says it shouldn't be updated by renovate. 🤔