[fix] Returning null in cacheForValue() doesn't disable caching
#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to disable cache by using cacheForValue() method. See renoki-co#100
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 79.34% 79.34%
=======================================
Files 4 4
Lines 184 184
=======================================
Hits 146 146
Misses 38 38
Continue to review full report at Codecov.
|
rennokki
changed the title
null in cacheForValue() doesn't disable caching
|
Thanks. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to disable cache by using cacheForValue() method. See #100
Closes #100