Skip to content

Conversation

@mattirn
Copy link
Contributor

@mattirn mattirn commented Dec 24, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 24, 2018

Codecov Report

Merging #574 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #574      +/-   ##
===========================================
+ Coverage     94.63%   94.7%   +0.07%     
  Complexity      315     315              
===========================================
  Files             4       4              
  Lines          4045    4045              
  Branches        990     990              
===========================================
+ Hits           3828    3831       +3     
+ Misses           75      73       -2     
+ Partials        142     141       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 95.39% <0%> (+0.08%) 190% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ac5ad...086348e. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Dec 24, 2018

@mattirn Awesome, thank you very much!
I will include this in the upcoming picocli 3.9 release, planned for end of this week.

Question: would it make sense to put this in a separate module: picocli-shell-jline3? What do you think?

@mattirn
Copy link
Contributor Author

mattirn commented Dec 24, 2018

@remkop thank you for the awesome work! I have created a separate module....

Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quick! I have a few nitpicks about the documentation (there’s some mentions of JLine 2 that we should change to 3) but otherwise this is exactly what I had in mind. Thank you very much!

@remkop remkop merged commit cfc1106 into remkop:master Dec 25, 2018
@remkop remkop changed the title added picocli JLine3 example Add picocli-shell-JLine3 module Dec 25, 2018
@remkop remkop added type: API 🔌 theme: shell An issue or change related to interactive (JLine) applications labels Dec 25, 2018
@remkop remkop added this to the 3.9 milestone Dec 25, 2018
remkop added a commit that referenced this pull request Dec 25, 2018
@remkop
Copy link
Owner

remkop commented Dec 25, 2018

Merged and updated release notes.
Thank you very much for this PR!

@mattirn mattirn deleted the jline3 branch January 3, 2019 18:49
@mattirn mattirn restored the jline3 branch January 3, 2019 18:50
@remkop
Copy link
Owner

remkop commented Jan 5, 2019

I’m releasing 3.9, but I’m having some trouble publishing thepicocli-shell-jline3 module to Bintray/Maven Central. It will likely appear a bit after the other modules.

@remkop
Copy link
Owner

remkop commented Jan 5, 2019

The picocli-shell-jline3 module is now available in Maven Central and Bintray.

@mattirn mattirn deleted the jline3 branch January 6, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: shell An issue or change related to interactive (JLine) applications type: API 🔌

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants