Fix path completion not working with directory names #1863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewbieOrange
force-pushed
the
bugfix/complete_dir
branch
2 times, most recently
from
4da5623 to
3ff446c
Compare
NewbieOrange
changed the title
NewbieOrange
changed the title
NewbieOrange
force-pushed
the
bugfix/complete_dir
branch
from
3ff446c to
cbc3ecc
Compare
remkop
approved these changes
Oct 30, 2022
remkop
requested changes
Oct 30, 2022
Owner
remkop
left a comment
remkop
left a comment
There was a problem hiding this comment.
Thank you for taking care of this!
I fixed an unrelated broken test, but now I see a number of failing tests for AutoComplete:
picocli.AutoCompleteHyphenatedCommandTest > testCompletionScript FAILED
org.junit.ComparisonFailure at AutoCompleteHyphenatedCommandTest.java:28
picocli.AutoCompleteTest > testBashify FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:1270
picocli.AutoCompleteTest > nestedSubcommands FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:192
picocli.AutoCompleteTest > basic FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:97
picocli.AutoCompleteTest > testBashifyWithExtras FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:12[82](https://github.com/remkop/picocli/actions/runs/3355881768/jobs/5560665264#step:8:83)
picocli.AutoCompleteTest > helpCommand FAILED
org.junit.ComparisonFailure at AutoCompleteTest.java:208
stty: /dev/tty: No such device or address
2319 tests completed, 6 failed, 27 skipped
Can you take a look?
NewbieOrange
force-pushed
the
bugfix/complete_dir
branch
from
f969c11 to
8450ceb
Compare
remkop
approved these changes
Oct 31, 2022
Owner
remkop
left a comment
remkop
left a comment
There was a problem hiding this comment.
@NewbieOrange Thank you for making the tests pass!
Owner
|
Merged! |
remkop
added
type: bug 🐛
theme: auto-completion
Owner
|
@NewbieOrange question for you: does this PR also solve the problem mentioned in #1759 (spaces in completion candidates)? |
Contributor
Author
No it doesnt. Similar changes (like #1759, but it might need some changes) need to be implemented for that situation to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1644