Update patterns that our compiler will complain about. #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling getClass() is likely to return an internal Proxy class (ie com.sun.proxy.$Proxy1) so use annotationType() instead. Assignment in an if statement is ambiguous so wrap in parens to make it obvious that it's intended. This are things that our compiler will fail on.
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
=========================================
Coverage 94.25% 94.25%
Complexity 455 455
=========================================
Files 2 2
Lines 6689 6689
Branches 1799 1799
=========================================
Hits 6305 6305
Misses 106 106
Partials 278 278
Continue to review full report at Codecov.
|
Owner
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling getClass() is likely to return an internal Proxy class (ie
com.sun.proxy.$Proxy1) so use annotationType() instead.
Assignment in an if statement is ambiguous so wrap in parens to make it
obvious that it's intended.
This are things that our compiler will fail on.