Skip to content

Conversation

@sakata1222
Copy link
Contributor

@sakata1222 sakata1222 commented Jun 20, 2020

I found a typo in the "Guice Example".

  • The method variable name of GuiceFactory#create is aClass.
  • I think the 1st argument of new CommandLine should have annotations of picocli, so we should specify a implemented class (i.e. InjectionDemo.class) not Runnable.class
  • If we specify the implemented class, bind definition for Runnable.class might be unnecessary.

fix typo in "Guice Example"
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2020

Codecov Report

Merging #1116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1116   +/-   ##
=========================================
  Coverage     94.36%   94.36%           
  Complexity      448      448           
=========================================
  Files             2        2           
  Lines          6633     6633           
  Branches       1782     1782           
=========================================
  Hits           6259     6259           
  Misses           99       99           
  Partials        275      275           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2b2ac...3d19c49. Read the comment docs.

@sakata1222
Copy link
Contributor Author

I found the other mistakes, I will update and reopen this pull request.

@sakata1222 sakata1222 closed this Jun 20, 2020
- fix 1st argument of new CommandLine
- remove unnecessary bind
@sakata1222 sakata1222 reopened this Jun 20, 2020
@remkop remkop merged commit 09061f0 into remkop:master Jun 20, 2020
@remkop
Copy link
Owner

remkop commented Jun 20, 2020

Merged into master.
Thank you for the contribution!

remkop added a commit that referenced this pull request Jun 20, 2020
@remkop remkop added this to the 4.4 milestone Jun 20, 2020
@sakata1222 sakata1222 deleted the DOC/fix-typo branch June 21, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants