-
Notifications
You must be signed in to change notification settings - Fork 446
Add tests for methods modified in #997 #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry I'm not quite familiar with pull requests. |
|
Hi @licia-tia, thank you for the pull request! The comment for your last commit says "DO NOT MERGE" but everything looks okay to me. |
|
We were doing a course project and our teacher asked us to test every method modified. I thought code modified by #1002 was covered by other tests and tests I added may not help, so I added: "DO NOT MERGE" to the commit. It's surely ok if you think those were helpful! |
|
@licia-tia no worries! :-) Please also thank your teacher for me. Is your teacher @wycers? |
|
Nooo😂 I'm also a student in the same course. And I'm in the same group as @licia-tia |
|
Please thank your teacher for me! 🙇 |
|
LOL, I will. @NewbieOrange @jerrylususu @hannnnnn @Linyer-qwq @Lyther are also my partners. Surprise! 😆 |
|
Well, @NewbieOrange @jerrylususu @hannnnnn @Linyer-qwq @Lyther @licia-tia @wycers and your teacher: I think you are all awesome! 🥇 👍 🥰 |
No description provided.