Skip to content

Conversation

@licia-tia
Copy link
Contributor

No description provided.

@licia-tia licia-tia closed this May 7, 2020
@licia-tia licia-tia reopened this May 7, 2020
@licia-tia
Copy link
Contributor Author

Sorry I'm not quite familiar with pull requests.

@remkop
Copy link
Owner

remkop commented May 7, 2020

Hi @licia-tia, thank you for the pull request!

The comment for your last commit says "DO NOT MERGE" but everything looks okay to me.
I am happy to merge this into master.
Can I go ahead?

@remkop remkop added type: enhancement ✨ theme: usagehelp An issue or change related to the usage help message labels May 7, 2020
@remkop remkop added this to the 4.3 milestone May 7, 2020
@licia-tia
Copy link
Contributor Author

licia-tia commented May 7, 2020

We were doing a course project and our teacher asked us to test every method modified. I thought code modified by #1002 was covered by other tests and tests I added may not help, so I added: "DO NOT MERGE" to the commit. It's surely ok if you think those were helpful!

@licia-tia
Copy link
Contributor Author

"Add tests for #1033" is actually for #1002, I made a wrong commit message. :-(

@remkop remkop merged commit a3c9340 into remkop:master May 7, 2020
@remkop
Copy link
Owner

remkop commented May 7, 2020

@licia-tia no worries! :-)
Thank you for the pull request! I merged it into master. 👍

Please also thank your teacher for me. Is your teacher @wycers?

@wycers
Copy link
Contributor

wycers commented May 7, 2020

Nooo😂 I'm also a student in the same course. And I'm in the same group as @licia-tia

@remkop
Copy link
Owner

remkop commented May 7, 2020

Please thank your teacher for me! 🙇
It is very nice to get so many helpful pull requests!

@wycers
Copy link
Contributor

wycers commented May 7, 2020

LOL, I will. @NewbieOrange @jerrylususu @hannnnnn @Linyer-qwq @Lyther are also my partners. Surprise! 😆

remkop added a commit that referenced this pull request May 7, 2020
@remkop
Copy link
Owner

remkop commented May 7, 2020

Well, @NewbieOrange @jerrylususu @hannnnnn @Linyer-qwq @Lyther @licia-tia @wycers and your teacher: I think you are all awesome! 🥇 👍 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: usagehelp An issue or change related to the usage help message type: enhancement ✨

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants