Skip to content

Conversation

@Lyther
Copy link
Contributor

@Lyther Lyther commented May 7, 2020

Hi Remkop,
For issue #1028 , I've added descriptions about java 15's text block in user manual in both html and adoc files.
This may save your time of writing document.
Enderaoe

@Lyther Lyther changed the title add description about text blocks add description about text blocks (#1028) May 7, 2020
@remkop
Copy link
Owner

remkop commented May 7, 2020

Hi @Lyther, thank you!
I was hoping to include a working example in the documentation.
Would it be possible for you to provide a working example that you have tested on Java 15?

@Lyther
Copy link
Contributor Author

Lyther commented May 7, 2020

Hi @remkop
I've added an example in description and tested under Java 15, it works fine.
The user manual would look like this now:
That's a pleasure to contribute to this awesome project.
Enderaoe

@remkop remkop added type: doc 📘 type: enhancement ✨ theme: usagehelp An issue or change related to the usage help message labels May 7, 2020
@remkop remkop added this to the 4.3 milestone May 7, 2020
@remkop remkop merged commit bf8e58c into remkop:master May 7, 2020
@remkop
Copy link
Owner

remkop commented May 7, 2020

Merged into master.
Thank you for the contribution!
I will update the release-notes later.

remkop added a commit that referenced this pull request May 7, 2020
@remkop
Copy link
Owner

remkop commented May 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: usagehelp An issue or change related to the usage help message type: doc 📘 type: enhancement ✨

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants