Skip to content

fix dynamic css selectors#11034

Merged
mjackson merged 1 commit intomainfrom
ryan/fix-selectors
Feb 6, 2026
Merged

fix dynamic css selectors#11034
mjackson merged 1 commit intomainfrom
ryan/fix-selectors

Conversation

@ryanflorence
Copy link
Member

@ryanflorence ryanflorence commented Feb 4, 2026

css={{
  '&:hover': pending ? undefined : { background: 'white' }
}}

broke, now it doesn't.

also got rid of some type casting

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Preview Build Available

A preview build has been created for this PR. You can install it using:

pnpm install "remix-run/remix#preview/pr-11034&path:packages/remix"

This preview build will be updated automatically as you push new commits.

@mjackson mjackson merged commit a393a02 into main Feb 6, 2026
6 checks passed
@mjackson mjackson deleted the ryan/fix-selectors branch February 6, 2026 04:18
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

The preview branch preview/pr-11034 has been deleted now that this PR is merged/closed.

@mjackson
Copy link
Member

mjackson commented Feb 6, 2026

Looks good, just missing a .changes file, which means it won't be published on the next release. I'll make one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants