Skip to content

Upgrade repository to pnpm 11#15202

Merged
brophdawg11 merged 4 commits into
mainfrom
brophdawg11/codex-upgrade-pnpm-11
Jun 18, 2026
Merged

Upgrade repository to pnpm 11#15202
brophdawg11 merged 4 commits into
mainfrom
brophdawg11/codex-upgrade-pnpm-11

Conversation

@brophdawg11

@brophdawg11 brophdawg11 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • upgrade the repo package manager metadata and lockfile to pnpm 11
  • move pnpm config into pnpm-workspace.yaml, including allowBuilds for pnpm 11 installs
  • keep the react-is override but drop the unified override since unified already resolves to 11.0.5
  • keep the existing pnpm/action-setup plus actions/setup-node workflow shape while bumping release.yml to pnpm/action-setup@v6

Verification

  • pnpm install --lockfile-only
  • pnpm install --frozen-lockfile --lockfile-only
  • ./node_modules/.bin/prettier --check package.json pnpm-workspace.yaml .github/workflows/*.yml
  • ruby -e 'require "yaml"; Dir[".github/workflows/*.yml"].each { |f| YAML.load_file(f); puts f }'
  • git diff --check

@brophdawg11
Upgrade repository to pnpm 11
4f910a6 
Assisted-By: devx/988c1e2f-7688-4786-a6e7-89ad2f4a9d6e
@github-actions

github-actions Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ No Change File Found

This PR doesn't include a change file which is used for automated release notes.
If your change affects users, please add one (or more) change files and commit the generated file(s).

pnpm run changes:add

This script requires Node 24+. If you are on a lower version, please add a file manually

Not every PR needs a change file — you can skip this step if the change is internal-only
(tests, tooling, docs)

@brophdawg11 brophdawg11 added the dependencies Pull requests that update a dependency file label Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Preview Build Available

Preview builds have been created for this PR. You can install react-router using:

pnpm install "remix-run/react-router#preview/pr-15202&path:packages/react-router"

And/or install other packages via:

pnpm install "remix-run/react-router#preview/pr-15202&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15202&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15202&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15202&path:packages/react-router-serve"

These preview builds will be updated automatically as you push new commits.

brophdawg11
brophdawg11 commented Jun 18, 2026
View reviewed changes
Comment thread .github/workflows/preview.yml
git push --force --set-upstream origin preview/pr-${{ github.event.pull_request.number }}
echo "pushed installable branch: https://github.com/$GITHUB_REPOSITORY/commit/$(git rev-parse HEAD)"
pnpm run previews:pr comment ${{ github.event.pull_request.number }} preview/pr-${{ github.event.pull_request.number }}
node ./scripts/previews/pr.ts comment ${{ github.event.pull_request.number }} preview/pr-${{ github.event.pull_request.number }}

@brophdawg11 brophdawg11 Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to raw node executions here because pnpm run seems to catch the now-out of date lockfile because we just manually overrode package.json files with new preview versions

brophdawg11
brophdawg11 commented Jun 18, 2026
View reviewed changes
Comment thread package.json
Comment on lines -103 to -104
"react-is": "19.1.0",
"unified": "11.0.5"

@brophdawg11 brophdawg11 Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These move to the workspace in pnpm 11 but I don't think these are needed anymore. unified is now at 11.0.5 without this. react-is seems to only be used by lint/test stuff and that's all passing without the override

brophdawg11
brophdawg11 commented Jun 18, 2026
View reviewed changes
Comment thread pnpm-workspace.yaml
Comment on lines +8 to +13
allowBuilds:
esbuild: false
msw: false
sharp: false
unrs-resolver: false
workerd: false

@brophdawg11 brophdawg11 Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT we don't actually need any of these to build - so leaving them as false until we figure out if we need them to

@brophdawg11 brophdawg11 marked this pull request as ready for review June 18, 2026 15:49
@brophdawg11 brophdawg11 merged commit 8b2f041 into main Jun 18, 2026
13 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/codex-upgrade-pnpm-11 branch June 18, 2026 17:06
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The preview branch preview/pr-15202 has been deleted now that this PR is merged/closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brophdawg11