Closed
Conversation
since paths do not uniquely identify routes when layout routes are used
|
Closed
Contributor
Author
|
Note: need to update test fixtures to |
Contributor
Author
|
Type-safe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12373
This PR refactors typegen to be "route ID centric" based on the route manifest produced by
routes.ts.This architecture better supports the fixes/features also added in this PR:
matchesare typed to be precise for child routeshrefuseRouteTODO
{}for paths that have only optional params is good or badroute-modules,register.ts, etc.app/)handlewithinmatchesloaderDatawithhydrate = truerespectsHydrateFallbackset in parent routeshref
Construct type-safe paths for navigation with
href: