Skip to content

docs: add additional JSDocs to NavigateOptions#12710

Merged
brookslybrand merged 1 commit intoremix-run:mainfrom
alexanderson1993:patch-3
Jan 9, 2025
Merged

docs: add additional JSDocs to NavigateOptions#12710
brookslybrand merged 1 commit intoremix-run:mainfrom
alexanderson1993:patch-3

Conversation

@alexanderson1993
Copy link
Contributor

These should appear both in VS Code and other IDEs, as well as in the reference docs website.

These should appear both in VS Code and other IDEs, as well as in the reference docs website.
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: 057f879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brookslybrand brookslybrand changed the title Add additional JSDocs to NavigateOptions docs: add additional JSDocs to NavigateOptions Jan 9, 2025
Copy link
Contributor

@brookslybrand brookslybrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @alexanderson1993, there's a lot of room for improvements like these, so thanks for helping chip away

@brookslybrand brookslybrand merged commit a3e4b8e into remix-run:main Jan 9, 2025
5 checks passed
@alexanderson1993 alexanderson1993 deleted the patch-3 branch January 9, 2025 19:58
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.1.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.3-pre-v6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants