Better fix for uaehf bug #18
Merged
+36
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toni Wilen recommended that the code should perform another open without closing the existing ioreq to work around this bug on some versions of UAE Also there was a chance that if an error occurred inside `scsi_inquiry` / `scsi_read_capacity` that caused OpenDevice to fail then CloseDevice in `scan_scsi_devices` would be called on an already closed IO
reinauer
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toni Wilen recommended that the code should perform another open without closing the existing ioreq to work around this bug on some versions of UAE
Also there was a chance that if an error occurred inside
scsi_inquiry/scsi_read_capacitythat caused OpenDevice to fail then CloseDevice inscan_scsi_deviceswould be called on an already closed IO