Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1689 +/- ##
=======================================
Coverage 72.80% 72.80%
=======================================
Files 228 228
Lines 13600 13600
=======================================
Hits 9901 9901
Misses 2967 2967
Partials 732 732
|
clevinson
approved these changes
Dec 16, 2022
Member
clevinson
left a comment
There was a problem hiding this comment.
Ran ack "1\.18" locally to verify there wasn't any extraneous usage of 1.18.
lgtm! thanks @ryanchristo
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
(cherry picked from commit 3f7a601)
ryanchristo
added a commit
that referenced
this pull request
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref: regen-network/cosmos-sdk#49
Using go version 1.18 versus 1.19 with cosmos sdk v0.46 will produce different snapshot hashes. This pull request bumps all modules to use go 1.19 and updates the go version check to require go 1.19. Bumping the go version caused a lint warning to become an error so this pull request also replaces the use of
io/ioutilwithos.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change