Skip to content

chore: update TypeScript version to 5.8 #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

aryaemami59
Copy link
Member

@aryaemami59 aryaemami59 commented Mar 7, 2025

This PR:

  • Bumps TypeScript to version 5.8.
  • Adds TypeScript 5.8 to TS versions to test against during CI.
  • Remove TypeScript versions lower than 5.0 from the CI matrix.

@aryaemami59 aryaemami59 self-assigned this Mar 7, 2025
Copy link

codesandbox bot commented Mar 7, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codesandbox-ci bot commented Mar 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37caa51:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 37caa51
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/67d650d311fc52000885ffec
😎 Deploy Preview https://deploy-preview-4882--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@timdorr
Copy link
Member

timdorr commented Mar 8, 2025

On our test suite, how far back do we want to go on the Typescript versions? 5.1 is coming up on 2 years old, so not the youngest version but not that far behind. More of a question than anything else.

@aryaemami59
Copy link
Member Author

aryaemami59 commented Mar 8, 2025

@timdorr Not sure tbh but we just got rid of <5.0 I'd say let's stick with this for at least a little while then I can get rid of 5.0 and 5.1 if everyone else is okay with it.

Edit: Looks like we're currently pretty much in sync with defnitely typed (oldest supported version is 5.0). As soon as 5.9 is released we can remove 5.0.

@aryaemami59 aryaemami59 added the Tooling Updates and improvements to internal development tools, scripts, and automation. label Mar 16, 2025
@aryaemami59 aryaemami59 force-pushed the chore/ts-5.8 branch 4 times, most recently from a9e5f7b to 2670641 Compare March 16, 2025 04:11
@EskiMojo14 EskiMojo14 merged commit d624fa3 into reduxjs:master Mar 16, 2025
62 checks passed
@aryaemami59 aryaemami59 deleted the chore/ts-5.8 branch March 16, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Updates and improvements to internal development tools, scripts, and automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants