fallthrough actions

[smeijer]

In normal reducers we can use fallthrough to use the same reducing method for multiple action types. What's the easy way to do this in redux-actions?

// normal reducer
switch (action.type) {
    case FETCH_ERROR:
    case CREATE_ERROR:
    case EDIT_ERROR:
    case DELETE_ERROR:
      return state
        .set('phase', ERROR)
        .set('error', String(action.payload.error));

  default:
    return state;
}

// redux-actions
handleActions({
  [FETCH_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

  [CREATE_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

  [EDIT_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

  [DELETE_ERROR]: (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));
}, {});

Is this even possible?

I realize I can create a small helper function, and call this function 4 times, but still it doesn't look very nice:

// redux-actions
const setError = (state, { payload }) => state
    .set('phase', ERROR)
    .set('error', String(payload.error));

handleActions({
  [FETCH_ERROR]: setError,
  [CREATE_ERROR]: setError,
  [EDIT_ERROR]: setError,
  [DELETE_ERROR]: setError,
}, {});

Anyone with suggestions to handle this in a clean way?

[xiaohanzhang]

have you checked combineActions ?

[yangmillstheory]

Yep, please see https://github.com/acdlite/redux-actions/#combineactionsactiontypes. Thanks @xiaohanzhang.

[smeijer]

Yes, I did see combineActions. But even after rereading this section several times, it's not directly obvious how to handle this case.

[yangmillstheory]

This is how we usually use it in code:

handleActions({
  [
    combineActions(
      FETCH_ERROR,
      CREATE_ERROR,
      EDIT_ERROR,
      DELETE_ERROR
    )
  ]: (state, { payload }) => state
      .set('phase', ERROR)
      .set('error', String(payload.error));
}, {});

[smeijer]

That one is briljant. Can't believe it's not that obviously noted in the readme.

[yangmillstheory]

@smeijer Would you mind submitting a PR to improve the README?

[yangmillstheory]

Actually, this is taken care of in https://github.com/acdlite/redux-actions/pull/165/files.