feat: Add ACLLog to rueidiscompat #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blueBlue0102, thank you so much but could you keep the ClientInfo parser in the |
blueBlue0102
force-pushed
the
add-acl-log
branch
from
25a1931 to
b1c175e
Compare
|
Hi @rueian, I've already moved it back to |
rueian
approved these changes
Feb 9, 2025
|
Thanks again. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#737
I have run the unit tests multiple times locally, and each time, a different test seems to fail unpredictably.
I'm not sure if this is an issue specific to my local environment.
Unit test results:
